Conversation
The gate on main ran between the release merge and the tag push and failed on "newest tag v1.5.0 does not match VERSION 1.6.0". The rule is now that the newest tag is never newer than VERSION; a VERSION ahead of the tags prints a release-pending note. The exact match at a tag stays with the release workflow. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019LJvVaoT3vhaJj7k9LBzEn
Open
12 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainfailed after the v1.6.0 release because it checked outmainseconds beforescripts/release.shpushed the tag, and the lint required the newest tag to equal VERSION. The main-branch rule is now that the newest tag is never newer than VERSION, with a release-pending note when VERSION is ahead; the exact match at a tag is already verified by the release workflow.Test plan
LINT_CHECK_TAG=1 bash scripts/lint.shpasses with tag v1.6.0 and VERSION 1.6.0mainafter the merge